Add support for more block tags (e.g. finalized, safe) in Filecoin.EthGetLogs

Open
#6,411 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
api, blockchain

Research direction

Start with the referenced Lotus implementation at node/impl/eth/events.go lines 576-585 and review how Filecoin.EthGetLogs currently handles block tags. Clarify the requirements and use cases for finalized and safe, then consider the work complete when those tags are supported with agreed behavior.

Written by the indexing model from the issue text.

Description

Ethereum supports more block tags than just "latest" and "earliest" (e.g. "finalized" and "safe"), but lotus does not handle these as of now.

This issue tracks adding support for these block tags in the future once requirements and use-cases are better defined.

Ref: https://github.com/filecoin-project/lotus/blob/df9e10ef0af35613c65178a5740fde37c03efc8e/node/impl/eth/events.go#L576-L585

Dominant language
Rust
Stars
700
Forks
201
Avg merge
1d 17h
Merged PRs (30d)
65

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ChainSafe/forest

All issues in ChainSafe/forest

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.