7 of 13 RATE_LIMIT_IDS are declared but never called, so those endpoints have no rate limit
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
Research direction
Start with apps/web/lib/rate-limit.ts and inspect how RATE_LIMIT_IDS is referenced outside its declaration. Compare the two named routes, apps/web/app/api/settings/billing/guest-checkout/route.ts and apps/web/app/api/analytics/track/route.ts, with apps/web/app/api/docs/ask/route.ts. Done means the declared IDs are either called by their endpoints or removed, with a regression test preventing unused IDs.
Written by the indexing model from the issue text.
Description
Summary
RATE_LIMIT_IDS in apps/web/lib/rate-limit.ts declares 13 rule ids, each with a doc comment naming the abuse it guards and a suggested window. 7 of them are never referenced anywhere in the codebase, so the endpoints they describe run with no rate limit at all.
Counting references outside the declaration file itself:
| id | referenced | endpoint it names |
|---|---|---|
AGENT_TOKEN_EXCHANGE |
2 | wired |
AGENT_AUTHORIZATION |
2 | wired |
AGENT_UNLOCK |
1 | wired |
AGENT_LOOM_IMPORT |
2 | wired |
TRANSLATE_TRANSCRIPT |
1 | wired |
DOCS_ASK |
1 | wired |
AUTH_OTP_VERIFY |
0 | Email OTP verification (brute-force guard) |
AUTH_OTP_SEND |
0 | Email OTP / magic-link send (mailbomb + token-reseed) |
LOOM_DOWNLOAD |
0 | Unauthed Loom download/convert (ffmpeg + memory DoS) |
MESSENGER_MESSAGE |
0 | Anonymous support chat (Groq + Supermemory cost) |
ANALYTICS_TRACK |
0 | Unauthed view tracking (Tinybird ingest + notifications) |
GUEST_CHECKOUT |
0 | Unauthed guest checkout (Stripe object/cost abuse) |
DESKTOP_LOGS |
0 | Unauthed desktop log to Discord forwarding (spam) |
$ grep -rn AUTH_OTP_VERIFY apps packages --include='*.ts' --include='*.tsx' | grep -v lib/rate-limit.ts
(no output)
Same for the other six.
Why this is easy to miss
The file's own comment explains that a rule id with no matching Vercel Firewall dashboard rule fails open:
An ID that has no matching dashboard rule fails OPEN (
checkRateLimitreturns{ rateLimited: false, error: "not-found" }) ... but it also provides no protection until the rule exists.
So there is already one silent-failure mode by design. A declared-but-uncalled id is a second one, and it is invisible from the dashboard side too: someone can create rl_guest_checkout in the Firewall, see it configured, and reasonably assume the endpoint is protected while no code ever calls it.
Two of the unprotected endpoints, checked
apps/web/app/api/settings/billing/guest-checkout/route.ts — no isRateLimited, no getCurrentUser, no auth of any kind. It reads priceId and quantity from the JSON body and calls stripe().checkout.sessions.create(...) directly. Anyone can create unbounded Stripe checkout sessions.
apps/web/app/api/analytics/track/route.ts — no isRateLimited. It uses provideOptionalAuth, so anonymous requests are expected, and it writes to Tinybird and can trigger createAnonymousViewNotification / sendFirstViewEmail. That is the exact combination the comment describes ("Tinybird ingest + notifications").
I checked those two by reading the route files. I did not audit all seven endpoints in the same depth, and I would rather say so than imply a completeness I have not verified.
What "wired" looks like, for reference
apps/web/app/api/docs/ask/route.ts is the model:
if (
isLocallyRateLimited(ip) ||
(await isRateLimited(RATE_LIMIT_IDS.DOCS_ASK, { headers: request.headers }))
) {
return Response.json({ error: "Too many questions right now. Try again in a minute." }, { status: 429 });
}
Expected
Either each declared id is called at the endpoint it names, or the unused ones are removed so the constant does not imply protection that is not there.
Suggested direction
I would rather not blanket-wire seven endpoints in one PR without knowing the intent — some may be deliberately staged ahead of the dashboard rules being created. What I would suggest, and am happy to implement:
- A cheap regression guard: a unit test that asserts every key in
RATE_LIMIT_IDSis referenced at least once outside the declaration file. That turns "declared but never called" into a CI failure rather than something found by reading. - Then wire the endpoints, either all in one follow-up or one at a time, whichever you prefer to review.
I have (1) ready and will open a PR referencing this issue, since it is the part that holds regardless of what you decide about each endpoint. Tell me which of the seven you want wired and I will follow up.
- Dominant language
- Rust
- Stars
- 25k
- Forks
- 2.4k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 676
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CapSoftware/Cap
-
Captions panel does not offer to show an existing transcriptPossibly taken @thedavidweng claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CapSoftware/Cap#4276 · 1 comment ·
Maintainers usually reply within 1 day
-
Download, FAQ, privacy and terms pages have no meta descriptionPossibly taken @patrickballard claimed this 13 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
CapSoftware/Cap#3675 · 1 comment ·
Maintainers usually reply within 1 day
-
self hosting
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CapSoftware/Cap#2384 · 3 comments ·
Maintainers usually reply within 1 day
-
Dashboard pagination causes full page reloads on self-hosted CapPossibly taken @DipanshuAmbilkar03 claimed this 11 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CapSoftware/Cap#2305 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CapSoftware/Cap#1714 · 3 comments ·
Maintainers usually reply within 1 day
Similar issues
-
benchmark-review
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day
-
area:filesystem bug need-triage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
libracoder/kiri#364 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
matrix-org/matrix-rust-sdk#7495 ·
Maintainers usually reply within 1 day