Generation steps fails when OPENGL_INCLUDE_DIRS is a list

Open Beginner friendly
#197 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cmake, cpp
Domain
build-system

Research direction

Start in CMakeLists.txt at line 118 and inspect how OPENGL_INCLUDE_DIRS from find_package(OpenGL REQUIRED) is passed to bindgen. Reproduce generation with multiple OpenGL include directories, then verify that the generation step completes successfully without assuming a single directory.

Written by the indexing model from the issue text.

Description

When calling find_package( OpenGL REQUIRED ) the variable OPENGL_INCLUDE_DIRS can return more than one directory. This causes a failure in the call to bindgen (https://github.com/CadQuery/OCP/blob/d69b064a3a604ebf245b1f3b14fb54c835a3a571/CMakeLists.txt#L118) where it is assumed that the variable only contains one directory.

Dominant language
C++
Stars
200
Forks
48
Avg merge
2d 2h
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CadQuery/OCP

All issues in CadQuery/OCP

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.