V2:Add dependency on the vulkan-headers package in the build scripts

Open Beginner friendly
#133 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
cpp
Domain
build-system

Research direction

Start from the build script that declares this project's dependencies; the issue does not name the file, so find where the existing packages are listed. Pull request #117 introduced the Vulkan usage, so check what it added. Add the vulkan-headers package to that dependency list, then confirm the build and CI pass. Done when a clean build no longer fails on missing Vulkan headers.

Written by the indexing model from the issue text.

Description

PR https://github.com/CachyOS/packageinstaller/pull/117 introduced Vulkan into the code. However, the build script does not currently declare the required header package (vulkan-headers) as a dependency., which causes the build to fail.
图片
Suggested addition:
图片
This issue has also caused CI builds to fail.
图片

Dominant language
C++
Stars
43
Forks
39
Avg merge
1d 6h
Merged PRs (30d)
12

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CachyOS/packageinstaller

All issues in CachyOS/packageinstaller

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.