OnSuccess/OnFailure properties as part of the rule - Security Issue

Open
#323 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
15/100
Issue type
Documentation
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
security

Research direction

Start by tracing how the onSuccess and onFailure function properties enter a rule, move from the server to the client, and are executed. Review the rule-storage and client-execution entry points to determine the security boundary; done means documenting whether this behavior is safe and what handling guidance applies.

Written by the indexing model from the issue text.

Description

There are 2 properties like Onsuccess and Onfailure property which can be a javascript function delegate and it is part of the rule right?

onSuccess: function(event,almanac) { console.log('hello success') },
onFailure : function(event,almanac) { alert('hello failed') }

Is it safe to store this as part of the rule in the database. Because the rule comes from the server to the client this script can be tampered by the hacker and we would end up executing a malicious script. Is that right?

Or Is my understanding wrong? Please confirm

Dominant language
JavaScript
Stars
3.1k
Forks
507
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CacheControl/json-rules-engine

All issues in CacheControl/json-rules-engine

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.