jsonpath-plus expects browser to use ESM

Open
#417 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
web-dev

Research direction

Start by reproducing the browser/Vitest failure when json-rules-engine loads jsonpath-plus, then trace how that dependency is loaded. Done means the rules engine can load and run in a browser without the reported ESM/CommonJS error; the issue names no files or tests to guide the change.

Written by the indexing model from the issue text.

Description

This library will no longer work in browser jsonpath-plus serves ESM when being used in the browser, however, this package only supports commonJS, so we get into a situation where if we are running this in a browser (vitest) we get an error when json-rules-engine tries to load jsonpath-plus

Dominant language
JavaScript
Stars
3.1k
Forks
507
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CacheControl/json-rules-engine

All issues in CacheControl/json-rules-engine

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.