Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Rule Ts incorrect

Open
#253 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, typescript
Domain
backend

Research direction

Start by inspecting rule.js and the type definitions that expose the rule.event property. Compare the refactored rule.ruleEvent property with the getEvent and setEvent accessors mentioned in the issue, then verify which form allows direct property access through the types. Done means the types match the runtime behavior and direct access works as intended.

Written by the indexing model from the issue text.

Description

The rule.js recently refactored the rule.event property to rule.ruleEvent (80e84b3ada7df7fca20aba21e37d8b5ee4257023) but there were no corresponding updates to the types when using the types accessing the property directly does not work as expected.

Should the type use rule.ruleEvent or should it use accessors for the event?

js & ts are not my speciality but i think the 'event' property of the interface needs to have a get function & set function that are actually the getEvent and setEvent functions.

Dominant language
JavaScript
Stars
3.1k
Forks
507
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CacheControl/json-rules-engine

All issues in CacheControl/json-rules-engine

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.