[BUG] Completed and canceled progress states are not treated as terminal
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start at progress_type_request and inspect how TestStatus.progress_step() and the stored TestStatus values are compared. Run the regression tests mentioned in the issue, and consider the work done when updates after both completed and canceled are rejected while the progress trail remains unchanged.
Written by the indexing model from the issue text.
Description
Description
progress_type_request does not correctly reject progress updates after a test has reached completed or canceled.
TestStatus.progress_step() returns an integer progress index, but the returned integer was compared directly against TestStatus.completed and TestStatus.canceled enum symbols.
As a result, terminal states could be incorrectly treated as active progress states.
Expected behavior
If the latest progress status is completed or canceled, a subsequent progress update should be rejected and the progress trail should remain unchanged.
Actual behavior
The terminal-state guard was bypassed, allowing additional progress entries after completed or canceled.
Reproduction
Regression tests demonstrate that:
- completed -> completed was accepted
- canceled -> completed was accepted
Fix
Compare the stored TestStatus enum directly against the terminal enum values, while retaining progress_step() for numeric progress ordering.
Tests
Regression tests cover both completed and canceled terminal states.
- Dominant language
- Python
- Stars
- 30
- Forks
- 85
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 21
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CCExtractor/sample-platform
-
Difficulty 3/5 1-2 days Newbie friendliness 84/100
CCExtractor/sample-platform#1192 ·
Maintainers usually reply within 6 days
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
CCExtractor/sample-platform#1082 ·
Maintainers usually reply within 6 days
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
CCExtractor/sample-platform#1079 ·
Maintainers usually reply within 6 days
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
CCExtractor/sample-platform#1062 · 2 comments ·
Maintainers usually reply within 6 days
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
CCExtractor/sample-platform#1057 ·
Maintainers usually reply within 6 days
All issues in CCExtractor/sample-platform
Similar issues
-
ACK_WAITING HELP_WANTED UPDATE_CS
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OWASP/CheatSheetSeries#2458 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
BasedHardware/omi#19711 ·
Maintainers usually reply within 1 day
-
Qwen3_5MoeModel no longer returns router_logits, breaking aux loss with output_router_logits=TrueOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
huggingface/transformers#49172 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vllm-project/vllm-metal#885 ·
Maintainers usually reply within 1 day