Support an arbitrary number of eras and avoid hard coding the era names
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 22/100
Research direction
Start from the discussion in pull request 644 about string-to-int era conversions. Trace how era names are currently hard-coded and how the science advisor maps era names to background pcx art in the JSON files. Decide on enums, ints, or another scheme that supports an arbitrary number of eras, then add the corresponding art-name mappings. Done means eras are no longer hard-coded and the advisor still finds the right backgrounds.
Written by the indexing model from the issue text.
Description
This came up in discussion in https://github.com/C7-Game/Prototype/pull/644; right now we have some string->int conversions related to eras, which isn't ideal. We should figure out a better way, either by using enums, or always using ints, or something along those lines.
Genuinely supporting a generic number of eras is interesting, but we'd need to be sure to have some art name mappings in the JSON files, since the science advisor needs a mapping from era name to background pcx.
- Dominant language
- C#
- Stars
- 662
- Forks
- 67
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 29
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from C7-Game/OpenCiv3
-
Add a Godot splashOpengodot good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 2 days
-
Add a zoom reset shortcutPossibly taken A pull request linked to this issue is open or already merged. Openenhancement godot good first issue graphics
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
C7-Game/OpenCiv3#1092 · 3 comments ·
Maintainers usually reply within 2 days
-
bug godot
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
Make temporary popups stickyPossibly taken @stavrosfa claimed this 11 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 2 days
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 2 days
All issues in C7-Game/OpenCiv3
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 80/100
Unity-Technologies/unity-agent-plugin#118 ·
Maintainers usually reply within 1 day
-
The Recommended preset turns on Import Uno DSP, which only works with the Material themePossibly taken @agneszitte claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
unoplatform/uno.templates#2388 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
eyalgolan/statecraft-israel#2732 ·
Maintainers usually reply within 1 day
-
要トリアージ
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
kind/chore status/draft
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Altinn/altinn-events#1158 ·
Maintainers usually reply within 1 day