SQLSelect — LeftJoin/RightJoin ByRef type mismatch

Open

#62 opened on Oct 16, 2025 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 1/5
Estimated time: Under an hour
Newbie friendliness: 55/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: sql
Domain: databases

Research direction

Open src/ClassModules/SQLSelect.cls around lines 120–143 and inspect the LeftJoin and RightJoin declarations and their calls to AddJoin. Compile or reproduce the strict-compilation case using string literals; done means both methods compile without the ByRef argument type mismatch.

Written by the indexing model from the issue text.

Description

SQLSelect: type LeftJoin/RightJoin params as String

Component: src/ClassModules/SQLSelect.cls (around 120–143)

Problem

Untyped parameters (Variant ByRef) cause mismatches when passed into AddJoin.

Snippet (actual)

Public Sub LeftJoin(sTable, sAlias, Optional sCondition As String = "")
    AddJoin "LEFT OUTER", sTable, sAlias, sCondition
End Sub

Public Sub RightJoin(sTable, sAlias, Optional sCondition As String = "")
    AddJoin "RIGHT OUTER", sTable, sAlias, sCondition
End Sub

Expected

Public Sub LeftJoin(sTable As String, sAlias As String, Optional sCondition As String = "")
    AddJoin "LEFT OUTER", sTable, sAlias, sCondition
End Sub

Public Sub RightJoin(sTable As String, sAlias As String, Optional sCondition As String = "")
    AddJoin "RIGHT OUTER", sTable, sAlias, sCondition
End Sub

Steps to Reproduce

Call LeftJoin/RightJoin with string literals under strict compilation.

Actual

Compile-time "ByRef argument type mismatch" in some contexts.

Proposed Fix

Type parameters as String.

Dominant language: VBA
Stars: 90
Forks: 18
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Document that a SQLite trail allows only one writer Open

documentation help wanted

Difficulty 2/5 1-3 hours Newbie friendliness 90/100

rajfirke/provena#202 · Opened Sep 22, 2026
Batched `completeJobs`/`failJobs` are never retried: the retry loop in `batch()` exits after the first failure Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

graphile/worker#636 · Opened Sep 21, 2026
Test Failure: com.ibm.ws.jdbc.fat.sqlserver.SQLServerTest J2CA0079E Open

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

OpenLiberty/open-liberty#35839 · Opened Sep 21, 2026
hash join v2: 'unsupported column type for pre-alloc 225' when joining on a VECTOR column Open

affects-9.0 found-by-ai may-affects-25.10 may-affects-26.3 may-affects-26.9 may-affects-7.5 may-affects-8.1 may-affects-8.5 severity/major sig/execution type/bug

Difficulty 2/5 1-3 hours Newbie friendliness 85/100

pingcap/tidb#71473 · Opened Sep 21, 2026
JSON_VALUE fails to parse when a RETURNING clause is present but the optional ON EMPTY/ON ERROR clause is omitted Open

Difficulty 1/5 Under an hour Newbie friendliness 92/100

antlr/grammars-v4#5014 · 1 comment · Opened Sep 21, 2026

More Databases issues