SQLSelect — union array not initialized & name mismatch

Open
#68 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
visualbasic
Domain
databases

Research direction

Read src/ClassModules/SQLSelect.cls, focusing on the declarations and Class_Initialize, then trace the UNION append and iteration paths. Done means the declared array name matches its references, it is initialized before UNION use, and the reproduction steps no longer fail or produce incorrect SQL.

Written by the indexing model from the issue text.

Description

SQLSelect: initialize aUnion and fix name mismatch

  • Component: src/ClassModules/SQLSelect.cls (declarations and initializer)
Problem
  • Declares sUnion() while other code references aUnion(); not initialized in Class_Initialize.
Expected
Private aUnion() As Variant

Private Sub Class_Initialize()
    ReDim aJoin(0)
    ReDim vFields(0)
    ReDim aOrder(0)
    ReDim aUnion(0)
    ' ...
End Sub
Steps to Reproduce
  1. Use UNION features without prior array setup.
Actual
  • Append/iteration fails or produces wrong SQL.
Proposed Fix
  • Rename to aUnion and ReDim in initializer.
Dominant language
VBA
Stars
90
Forks
18
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Beakerboy/VBA-SQL-Library

All issues in Beakerboy/VBA-SQL-Library

Similar issues

More Databases issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.