getB2FileInfo throws IllegalArgumentException on a value with a stray percent sign
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start in core/src/main/java/com/backblaze/b2/client/contentSources/B2Headers.java at getB2FileInfo (around line 216, where the value is passed to URLDecoder), then read percentDecode in core/src/main/java/com/backblaze/b2/util/B2StringUtil.java. Compare with the handling in B2Headers.java around lines 130-136, which already deals with a similar failure. Done when a value such as 100% no longer throws IllegalArgumentException and the raw value is kept, verified by a test that builds B2HeadersImpl with X-Bz-Info-note: 100% and calls getB2FileInfo().
Written by the indexing model from the issue text.
Description
What happens
getB2FileInfo() percent-decodes each file info value with URLDecoder, which throws IllegalArgumentException for a malformed sequence such as 100%. Building a file version from download headers calls it, so the whole download fails for a file whose info value was stored raw by another client. getFileNameOrNull() in the same interface catches the same exception and returns null.
Where
core/src/main/java/com/backblaze/b2/client/contentSources/B2Headers.java:210-219 (getB2FileInfo, decode at :216), core/src/main/java/com/backblaze/b2/util/B2StringUtil.java:46-52 (percentDecode), called from core/src/main/java/com/backblaze/b2/client/B2StorageClientWebifierImpl.java:618. Compare B2Headers.java:130-136.
Why it matters
Impact: Availability (a download or metadata read fails), loud. Severity: High, because it needs a file info value stored with an unencoded percent sign by a client other than this SDK (unusual), and there is no workaround for that file besides a different client.
How to check
Found by reading the code, not reproduced. Read getB2FileInfo and percentDecode. A test could build B2HeadersImpl with X-Bz-Info-note: 100% and call getB2FileInfo(). Catching IllegalArgumentException and keeping the raw value would avoid the failure.
Version
Seen at v6.5.0. Present on the default branch: present.
- Dominant language
- Java
- Stars
- 103
- Forks
- 23
- Avg merge
- 5d 8h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Backblaze/b2-sdk-java
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Backblaze/b2-sdk-java#248 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Backblaze/b2-sdk-java#247 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Backblaze/b2-sdk-java#245 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Backblaze/b2-sdk-java#242 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Backblaze/b2-sdk-java#241 ·
Maintainers usually reply within 3 days
All issues in Backblaze/b2-sdk-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
IETF-Hackathon/pqc-certificates#351 ·
Maintainers usually reply within 2 days
-
hermes-queue
Difficulty 2/5 Under an hour Newbie friendliness 72/100
chrisalunlloyd2-sudo/mindpalace#393 ·
Maintainers usually reply within 1 day
-
core-types enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
higher-kinded-j/higher-kinded-j#1509 ·
Maintainers usually reply within 1 day