B-Lang-org/bsc

update-build-version.sh: Allow setting git rev, instead of just NOGIT=1

Open

#12 opened on Feb 5, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (1,108 stars) (178 forks)batch import
buildgood first issue

Description

My build environment doesn't provide neither the git executable nor the .git folder, so I can only set NOGIT=1, but miss all version information, as this falls back to a bunch of zeroes.

It'd be much more convenient if the version string could be passed in via make flags.

Contributor guide

Tech stack
shell
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic shell scriptingunderstanding of make variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the script update build version.sh in the repository. Understand how version information is currently extracted using git or fallback to zeros. Then propose a make flag (e.g., GIT REV) that allows passing a custom git revision string. Ensure backward compatibility with NOGIT=1.