B-Lang-org/bsc

update-build-version.sh: Allow setting git rev, instead of just NOGIT=1

Open

#12 opened on Feb 5, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (178 forks)batch import
buildgood first issue

Repository metrics

Stars
 (1,108 stars)
PR merge metrics
 (Avg merge 17d 1h) (18 merged PRs in 30d)

Description

My build environment doesn't provide neither the git executable nor the .git folder, so I can only set NOGIT=1, but miss all version information, as this falls back to a bunch of zeroes.

It'd be much more convenient if the version string could be passed in via make flags.

Contributor guide

Research direction
Modify the `update build version.sh` script to accept an optional command line argument for the version string (e.g., ` v <version>`). When provided, use that instead of running `git describe`. Ensure it gracefully falls back to NOGIT=1 behavior when not provided.
Tech stack
shell
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitShell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70