Is this JSON relevant?

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
azure, csharp
Domain
cloud

Research direction

Review ARM-Templates/Add-Event-Subscriptions/azuredeploy.json, especially the role assignment around lines 35-45, and trace whether the sample uses that role elsewhere. Confirm whether the role assignment is required for the sample; document the conclusion and update the sample documentation or template accordingly.

Written by the indexing model from the issue text.

Description

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [X] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Does the following JSON matter in this sample:

            "type": "Microsoft.Sql/servers/providers/roleAssignments",
            "apiVersion": "2018-09-01-preview",
            "name": "[concat(parameters('sqlServerName'), '/Microsoft.Authorization/', guid(uniqueString(parameters('sqlServerName'))))]",
            "dependsOn": [
                "[resourceId('Microsoft.Web/sites', parameters('functionAppName'))]"
            ],
            "properties": {
                "roleDefinitionId": "[concat('/subscriptions/', subscription().subscriptionId, '/providers/Microsoft.Authorization/roleDefinitions/', '6d8ee4ec-f05a-4a1d-8b00-a9b17e38b437')]",
                "principalId": "[reference(resourceId('Microsoft.Web/sites', parameters('functionAppName')),'2019-08-01', 'Full').identity.principalId]"
            }
	    },

It doesn't seem like the role is needed anywhere.

Dominant language
C#
Stars
11
Forks
18
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Azure-Samples/KeyVault-Rotation-SQLPassword-Csharp

All issues in Azure-Samples/KeyVault-Rotation-SQLPassword-Csharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.