4.0 | Remove previously deprecated code
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by inspecting the listed WordPressVIPMinimum sniffs and their deprecated members, then review the referenced issues #858, #234, #517, #865, and #872 for scope and dependencies. The JavaScript sniffs are tracked separately in #442. Done means the listed deprecated PHP code is removed without including that separate work.
Written by the indexing model from the issue text.
Description
Removing the deprecated JS sniffs is tracked separately in #442.
List of deprecated code which should be removed in the next major:
-
WordPressVIPMinimum\Sniffs\Classes\DeclarationCompatibilitySniff::$checkClasses- deprecated since VIPCS 3.1.0, see #858, related to #234. -
WordPressVIPMinimum\Sniffs\Classes\DeclarationCompatibilitySniff::$checkClassesGroups- deprecated since VIPCS 3.1.0, see #858, related to #234. - The complete
WordPressVIPMinimum\Sniffs\Functions\DynamicCallssniff - deprecated since VIPCS 3.1.0, see #517 and #865 -
WordPressVIPMinimum\Sniffs\Performance\TaxonomyMetaInOptionsSniff::$option_functions- deprecated since VIPCS 3.1.0, see #872, related to #234. -
WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::$url_attrs- deprecated since VIPCS 2.3.1 -
WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::$attr_endings- deprecated since VIPCS 2.3.1 -
WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::attr_expects_url)_- deprecated since VIPCS 2.3.1 -
WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::is_html_attr()- deprecated since VIPCS 2.3.1
- Dominant language
- PHP
- Stars
- 261
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/VIP-Coding-Standards
-
AlwaysReturnInFilter: isInsideIfConditonal() guards the conditions array after reading itPossibly taken @tomjn claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Bug: PreGetPosts warns when the early is_main_query() return is not the first statement in its ifPossibly taken @tomjn claimed this 5 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
Suppress filters in get_posts false positivePossibly taken @tomjn claimed this 6 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
All issues in Automattic/VIP-Coding-Standards
Similar issues
-
Difficulty 2/5 Under an hour Newbie friendliness 78/100
opencart/opencart#15763 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
L: github:actions L: php:composer
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
dependabot/dependabot-core#16493 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
api-platform/core#8649 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
open-telemetry/opentelemetry-php#2071 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day