[Tech Debt] Change `TARGET_OS_IPHONE` macros in code
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Search the repository for every TARGET_OS_IPHONE occurrence and read the referenced pull requests for compatibility context. Determine the appropriate replacement macros and whether the deployment target must move to iOS 9.2; the work is done when all occurrences are updated and the project builds correctly under Xcode 10 and Swift 4.2.
Written by the indexing model from the issue text.
Description
Xcode 10 and Swift 4.2 no longer recognize the TARGET_OS_IPHONE macro, which was deprecated in Swift 3 and removed in 4.2. The side effect of this is that Xcode is now executing code that was not meant for simulators.
The code need reviewed and all TARGET_OS_IPHONE macros replaced. I don't have a specific recommendation because this project may also need updated to target iOS 9.2 instead of 9.0 for full compatibility with the new macros.
Ref. https://github.com/Automattic/Automattic-Tracks-iOS/pull/78
Ref. https://github.com/woocommerce/woocommerce-ios/pull/475
- Dominant language
- Swift
- Stars
- 47
- Forks
- 15
- Avg merge
- 1d 34m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/Automattic-Tracks-iOS
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
Automattic/Automattic-Tracks-iOS#305 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
Automattic/Automattic-Tracks-iOS#298 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
All issues in Automattic/Automattic-Tracks-iOS
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
area: desktop area: website priority: P2 type: feature
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
appandflow/stim#3411 · 1 comment ·
Maintainers usually reply within 1 day
-
Bug 🐞
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
mozilla-mobile/firefox-ios#36008 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ashvardanian/NumKong#397 · 1 comment · 1 reaction ·
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
harf-promo/decaffeinate#21 ·