Add tests for `logError` thread-safety / Make it return a value
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- swift
- Domain
- mobile-dev, testing
Research direction
Start with the commented usage in Tests/Tests/CrashLoggingTests.swift, lines 97–114, and read the referenced WordPress iOS discussion for the intended behavior. Determine the expected thread-safety coverage and return value before changing anything; done means those expectations are captured by tests and the requested behavior is verified.
Written by the indexing model from the issue text.
Description
See @salimbraksa's comment from Jetpack and WordPress iOS: https://github.com/wordpress-mobile/WordPress-iOS/pull/20846/files#r1231271865
I could only find one usage of logError in the tests, and is commented:
- Dominant language
- Swift
- Stars
- 47
- Forks
- 15
- Avg merge
- 1d 34m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/Automattic-Tracks-iOS
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
Automattic/Automattic-Tracks-iOS#305 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
Automattic/Automattic-Tracks-iOS#298 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
All issues in Automattic/Automattic-Tracks-iOS
Similar issues
-
builtin-port enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
cmlarsen/writemorebetter#235 ·
Maintainers usually reply within 1 day
-
bug-pending-triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
NativeScript/NativeScript#11525 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
callstack/agent-device#3627 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day