ArduPilot/ardupilot

Plane: Landing permanently disable geofence

Open

#5544 opened on Jan 11, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (9,336 stars) (15,603 forks)batch import
BUGPlaneSafetygood first issue

Description

Issue details

Once you begin a landing sequence the geofence can be disabled ( https://github.com/ArduPilot/ardupilot/blob/649ef0fc1614cacf823115cf8433319a4f8da563/ArduPlane/commands_logic.cpp#L404 ) but if you abort the landing or change modes for any reason the fence is never re enabled. (This is not related to AP_Landing changes, and is a pre existing bug)

Version

Master

Platform

[ ] All [ ] AntennaTracker [ ] Copter [ x ] Plane [ ] Rover

EDIT: Updated the link to the code to be useful/correct.

Contributor guide

Tech stack
cpp
Domain
security
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ArduPilotlanding logicgeofence
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the landing logic in ArduPilot/commands logic.cpp around line 404 where geofence is disabled. Trace how mode changes and landing aborts are handled to ensure the fence is re enabled. Review comments for any prior discussions or attempted fixes.