[Bug] I detected a few high priority urgent bugs

Open
#445 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
rust
Domain
backend, security

Research direction

Start in frontend/rust-lib/flowy-folder/src/manager.rs at get_workspace_public_view_pbs and inspect the child_views.retain filter alongside the top-level private_view_ids filter. Check any recursive child traversal or alternative public-view builders mentioned in the issue, then add coverage for private and trashed children under a public parent. Done means neither child appears publicly while the owner can still access the private child through private views.

Written by the indexing model from the issue text.

Description

Bug Description

I ran Appflowy through a scan on my app Apptruth and it detected several high priority urgent issues, including one like private pages nested under public pages can be exposed publically. (Another issue showed empty schedules queries crash the backend).

I took a screenshot of the first 2 issues.

I went and tested these 2 issues manually myself and they were confirmed to be not working as epxected.

There were 12 more (14 in total).

You can run the same check for yourself on apptruth.io

Image
Steps to Reproduce
  1. go to app
  2. create private page under public page
  3. private page is publically available without auth
The AI fix prompt

In get_workspace_public_view_pbs in frontend/rust-lib/flowy-folder/src/manager.rs, change the child-view filter to exclude both trash_ids and private_view_ids. Audit any recursive child traversal or alternative public-view builders and apply the same rule there. Add tests for a public parent with a private child and a trashed child; assert neither child appears in the public response while the owner can still access the private child through private views.

Expected Behavior

The code excludes private pages at the top level. But when it adds child pages beneath a public parent, it removes trashed pages only and does not remove private children.

Where it happens:
frontend/rust-lib/flowy-folder/src/manager.rs—get_workspace_public_view_pbs filters private_view_ids for top-level views, but its child_views.retain call checks only trash_ids; the method comment says public views should be filtered by trash and all private views.

Browser and Version

google chrome

AppFlowy Version(s)

latest version

Screenshots

No response

Logs and Console Output

No response

Additional Context

No response

Dominant language
TypeScript
Stars
354
Forks
186
Avg merge
1d 7h
Merged PRs (30d)
71

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AppFlowy-IO/AppFlowy-Web

All issues in AppFlowy-IO/AppFlowy-Web

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.