[Bug] Refactor this function to not always return the same value.
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- frontend
Research direction
Locate the shouldShowForCurrentView function and inspect its callers and related view-filtering logic to determine the original intent of currentView. Check whether the callback should distinguish views or can be removed, then verify that the resulting behavior matches the expected visibility rules and does not always return the same value.
Written by the indexing model from the issue text.
Description
Bug Description
The intention of this function is not clear. Take a look.
const shouldShowForCurrentView = useCallback(() => {
if (!currentView) return true;
// Show for all views
return true;
}, [currentView]);
Did you mean false in the if statement?
Steps to Reproduce
Take a look at the function and tell if there is any logic in it. What was the original intent?
Expected Behavior
Should return different values or this is not needed at all.
Browser and Version
Edge latest
AppFlowy Version(s)
0.15
Screenshots
No response
Logs and Console Output
No response
Additional Context
No response
- Dominant language
- TypeScript
- Stars
- 354
- Forks
- 186
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 71
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AppFlowy-IO/AppFlowy-Web
-
[Bug] The inline code block should have a monospaced fontPossibly taken @Rezapurian claimed this 143 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
AppFlowy-IO/AppFlowy-Web#394 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 22/100
AppFlowy-IO/AppFlowy-Web#692 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
[Bug] Unable to replace the selected text by pasted textMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
AppFlowy-IO/AppFlowy-Web#580 ·
Maintainers usually reply within 1 day
-
[Bug] Sidebar spaces appear empty after switching workspace (expand state is global and pruned per workspace; reload fixes it)Possibly taken @breken-ai claimed this 73 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 68/100
AppFlowy-IO/AppFlowy-Web#526 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
AppFlowy-IO/AppFlowy-Web#521 ·
Maintainers usually reply within 1 day
All issues in AppFlowy-IO/AppFlowy-Web
Similar issues
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/playwright#44289 ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 Half a day Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
blamechris/chroxy#9272 ·
Maintainers usually reply within 1 day
-
no-repo-link tool-submission
Difficulty 1/5 Under an hour Newbie friendliness 66/100
BraveOPotato/NoSignups#2458 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
drmrd/vernacular#1061 ·
Maintainers usually reply within 1 day