OAuth example should not infer org affiliation from the email field.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- jupyter-notebook, python
- Domain
- authentication, authorization
Research direction
Start with oauth_example/oa.py at the linked line, then inspect nbs/explains/oauth.ipynb for the analogous email-based affiliation check. Search the example repository and explainer for other uses of the email field in access decisions. Done means both examples follow Google's hd claim guidance and no email-based organization inference remains.
Written by the indexing model from the issue text.
Description
This example parses the user's email, returned from Google's authorization server, in order to determine if the user should have access:
However, Google says not to do this, and to use the "hd claim" instead:
We should update the example to follow Google's advice.
An analogous change will also be needed in the fasthtml explainer notebook: https://github.com/AnswerDotAI/fasthtml/blob/main/nbs/explains/oauth.ipynb
It may appear elsewhere as well.
- Dominant language
- CSS
- Stars
- 857
- Forks
- 131
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AnswerDotAI/fasthtml-example
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
AnswerDotAI/fasthtml-example#79 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
AnswerDotAI/fasthtml-example#69 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
AnswerDotAI/fasthtml-example#63 · 1 comment · 1 reaction ·
All issues in AnswerDotAI/fasthtml-example
Similar issues
-
Product: Azure Policy :shield: Topic: Diagnostic Settings :test_tube: Topic: Policy :pencil:
Difficulty 1/5 1-3 hours Newbie friendliness 92/100
Azure/Azure-Landing-Zones#4283 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MystenLabs/MemWal#979 · 1 comment ·
-
namespace operations
Difficulty 1/5 Under an hour Newbie friendliness 82/100
EclipseFdn/open-vsx.org#13384 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
documentation
Difficulty 2/5 Half a day Newbie friendliness 62/100
inmanta/inmanta-core#10835 ·