HTTP requests fail if password contains reserved characters
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- clickhouse, go, kubernetes
- Domain
- backend, databases, observability
Research direction
Start at connection.go:90 in the metrics-exporter, where the failed Ping request is logged, and reproduce the request with a password containing # or another reserved character. Trace how the ClickHouse HTTP basic-auth URL is assembled; done means reserved password characters are encoded correctly and the request succeeds without a parse error.
Written by the indexing model from the issue text.
Description
If the clickhouse_operator password contains a # character, HTTP requests using basic auth fail with a parse error.
It appears the metrics-exporter is not properly percent/URL-encoding.
E0916 22:38:06.764842 1 connection.go:90] connect():FAILED Ping(http://clickhouse_operator:***@HOSTNAME:8123/). Err: parse "http://clickhouse_operator:cs": invalid port ":cs" after host
In this case the password started with cs#.
- Dominant language
- Go
- Stars
- 2.6k
- Forks
- 577
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Altinity/clickhouse-operator
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Altinity/clickhouse-operator#2093 ·
Maintainers usually reply within 2 days
-
[Regression / Discussion] Loss of hot-reloaded password rotation after removal of k8s_secret_* in 0.27.4Possibly taken @sunsingerus claimed this 1 day ago. Openplanned for review
Difficulty 5/5 Over a week Newbie friendliness 38/100
Altinity/clickhouse-operator#2092 · 1 comment · 1 assignee ·
Maintainers usually reply within 2 days
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
Altinity/clickhouse-operator#2089 ·
Maintainers usually reply within 2 days
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
Altinity/clickhouse-operator#2064 · 3 comments ·
Maintainers usually reply within 2 days
-
big deployment planned for review
Difficulty 4/5 3-5 days Newbie friendliness 52/100
Altinity/clickhouse-operator#2063 ·
Maintainers usually reply within 2 days
All issues in Altinity/clickhouse-operator
Similar issues
-
Helm IPv4 host checks accept addresses Go rejectsPossibly taken @ericcaiwx-star claimed this today. Openclawsweeper:bulk-filed clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:other issue-rating: 🦞 diamond lobster P2
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
openclaw/openclaw-enterprise#1588 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
cvss-severity:high devguard l3montree-cybersecurity/devguard/devguard-web pkg:oci/devguard-web?rep...ch=amd64&tag=main-amd64 pkg:oci/devguard-web?rep...ch=arm64&tag=main-arm64 pkg:oci/web?repository_u...ch=amd64&tag=main-amd64 pkg:oci/web?repository_u...ch=arm64&tag=main-arm64 risk:low state:open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
l3montree-dev/devguard#3168 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
status:approved type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Gentleman-Programming/gentle-ai#5326 ·
Maintainers usually reply within 1 day
-
needs-acceptance wg/router-models-inference-runtime
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vllm-project/semantic-router#4663 ·
Maintainers usually reply within 1 day