Review runner: propagate PII abstention (parse_error) into the PII lane
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 67/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- backend, data-engineering, security
Research direction
Locate ReviewRunner.detectPii, the dispatcher runner handling checkQueryPii, and the orchestrator's PII lane. Trace how pii.parse_error currently becomes an empty columns result, then verify that abstained files are marked unverified while verified-clean files retain their existing behavior; add or run the relevant review-runner and orchestrator tests if present.
Written by the indexing model from the issue text.
Description
Follow-up from PR #1090 review (Codex P1, comment 3768687908): when the composite check's checkQueryPii abstains (data.pii.parse_error), the review runner's detectPii returns { columns: [] }, indistinguishable from a verified-clean result, and the PII lane treats the model as clean.
Practical exposure is currently nil — an unparseable model already fails the review loudly via the validation/lint lanes, and the abstention is visible in the composite output and fails closed in the CLI/tool paths — but for the "degrade loudly" contract the lane should know the difference.
Scope: extend ReviewRunner.detectPii to return an optional abstained flag (optional field, non-breaking for mocks), set it from pii.parse_error in the dispatcher runner, and have the orchestrator PII lane mark PII checks as unverified (rather than clean) for that file.
- Dominant language
- TypeScript
- Stars
- 813
- Forks
- 134
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 65
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AltimateAI/altimate-code
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
AltimateAI/altimate-code#1359 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
AltimateAI/altimate-code#1323 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
AltimateAI/altimate-code#1288 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
AltimateAI/altimate-code#1285 ·
-
privacy: Altimate Base consent dialog no longer discloses persistent per-installation identifier Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
AltimateAI/altimate-code#1284 ·
All issues in AltimateAI/altimate-code
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
bcgov/bc-wallet-mobile#4761 · 1 comment ·
-
external-issue to-triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
refactor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100