Confusing time stamps in TemporalFilter imshow function

Open
  • Is something wrong?
#370 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
data-visualization

Research direction

Start in bmtk/simulator/filternet/lgnmodel/temporalfilter.py at TemporalFilterCosineBump.imshow(), and reproduce the supplied snippet. Compare how the displayed timestamps and response alignment relate to the linked paper; done means confirming whether negative timestamps are required and correcting the axis if the behavior is a bug.

Written by the indexing model from the issue text.

Description

Hello, maintainers, thank you for contributing this great work to BMTK.
I have some questions that I would like to ask for help. When I refer to the document (https://alleninstitute.github.io/bmtk/tutorial_filter_models.html) to learn how to use the filter model, I find that the timestamps displayed by the TemporalFilter imshow function are confusing. There are two graphs with similar response characteristics but different timestamps, and the one generated by the BMTK code is probably the wrong one because the response characteristics are even less similar to those in the paper.

paper

Durand, S., Iyer, R., Mizuseki, K., Vries, S. de, Mihalas, S., & Reid, R. C. (2016). A Comparison of Visual Response Properties in the Lateral Geniculate Nucleus and Primary Visual Cortex of Awake and Anesthetized Mice. Journal of Neuroscience, 36(48), 12144–12156. https://doi.org/10.1523/JNEUROSCI.1741-16.2016
image

Reproduce code

from bmtk.simulator.filternet.lgnmodel.temporalfilter import TemporalFilterCosineBump
tf = TemporalFilterCosineBump(weights=[30, -20], kpeaks=[50, 100],  delays=[0.0, 0.0])
tf.imshow()

image

Question

Is this a bug, should I use negative values ​​for timestamps?

Dominant language
Python
Stars
340
Forks
104
Avg merge
3h 16m
Merged PRs (30d)
16

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AllenInstitute/bmtk

All issues in AllenInstitute/bmtk

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.