build_env_bionet fails when config_file is not explicitly provided

Open
  • Is something wrong?
#162 1 comment 2 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start at bmtk.utils.sim_setup.build_env_filternet and inspect how the optional config_file argument is passed to env_builder.build. Confirm the failure when config_file is omitted, then verify that the build uses env_builder's default without producing the invalid-value error.

Written by the indexing model from the issue text.

Description

The default value of None for the kwarg config_file to bmtk.utils.sim_setup.build_env_filternet is an invalid one and causes an error, since a string or Path is expected. I suggest only passing config_file to env_builder.build if it is not None, so that env_builder can specify its own correct default.

Dominant language
Python
Stars
339
Forks
103
Avg merge
2h 7m
Merged PRs (30d)
14

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AllenInstitute/bmtk

All issues in AllenInstitute/bmtk

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.