Ch 6 assignment of tuning angles inverted

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
jupyter-notebook
Domain
content

Research direction

Open Ch 6A and inspect cells In [9] and [11], focusing on the add_nodes() calls that set tuning_angles. Verify the conditional behavior for the tuning_angle value, then correct the inverted assignment and rerun those cells to confirm the expected angles are set.

Written by the indexing model from the issue text.

Description

In Ch 6A In [9] and [11], when "tuning_angles" are being set with the add_nodes() method only if the "tuning_angle" value in the dict is set to false. This is backwards.

Dominant language
Jupyter Notebook
Stars
9
Forks
10
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AllenInstitute/bmtk-workshop

All issues in AllenInstitute/bmtk-workshop

Similar issues

More Content issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.