Handle both legacy and current @type values in forward messages

Open
  • Is something wrong?
#119 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, node.js
Domain
api, backend

Research direction

Start by locating the forward-message handling and comparing its accepted @type values with the analogous aries-vcx pull request #341. Done means both the legacy did:sov value and the current https://didcomm.org value are supported without breaking existing messages; the issue names no implementation files or tests.

Written by the indexing model from the issue text.

Description

Currently, agency expects and uses legacy @type attribute for forward messages:

did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/routing/1.0/forward

However, as per aries spec (see here), a different value should be used for the attribute:

https://didcomm.org/routing/1.0/forward

Agency should support both formats for some time in order to remain backwards compatible.

Analogous change was already implemented in aries-vcx (see here).

Dominant language
JavaScript
Stars
23
Forks
8
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AbsaOSS/vcxagencynode

All issues in AbsaOSS/vcxagencynode

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.