Review security across the pipeline, and make the AquaSec scan run

Open
  • Is something wrong?
#134 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
github-actions, markdown
Domain
ci-cd, security

Research direction

Start with the "Aquasec Night Scan" workflow in each living-doc repository, where the run fails at configuration validation because AQUA_GROUP_ID and AQUA_REPOSITORY_ID are missing. Run gh run list -R AbsaOSS/<repository> --workflow "Aquasec Night Scan" --limit 1 to confirm the failure. Done means the secrets are set, or the workflow is removed where no values will come, and a per-stage threat model exists with hostile-content tests modelled on living-doc-generator-markdown's tests.

Written by the indexing model from the issue text.

Description

type:tech-debt
Description of Technical Debt

No security review covers the pipeline. That means untrusted authored content through every stage (issue bodies,
headers, HTML converted from Azure DevOps), the token scopes each collector needs, the composite actions' supply chain,
and dependency scanning beyond AquaSec.

AquaSec itself does not run. Every repository of the ecosystem has an "Aquasec Night Scan" workflow, and every one
failed its last run (2026-11-12) at configuration validation: AQUA_GROUP_ID and AQUA_REPOSITORY_ID are not provided,
so the scan exits before it scans. No scan result has ever existed.

Impact of Technical Debt
  • Unknown exposure in a public pipeline that renders authored content.
  • The nightly red runs look like coverage and train readers to ignore failures.
Category

Security

Priority

Medium - Should be addressed soon

Proposed Solution
  1. The owner gets the two organisation values and sets them as secrets in each repository, or removes the workflow
    where no values will come.
  2. A threat model per stage (inputs, outputs, tokens, third-party actions), with tests in the style of
    living-doc-generator-markdown's hostile-content tests.
  3. living-doc-generator-markdown's nested-list rendering of unindented lines (its own issue) is reviewed in it.
Effort Estimate

Secrets: 1 hour. Review: 3-5 days.

Dependencies / Related

No response

Additional Context

Measured 2026-11-12 at living-doc 2df73dc. Re-check:

gh run list -R AbsaOSS/<repository> --workflow "Aquasec Night Scan" --limit 1 for each living-doc* repository.

Dominant language
Python
Stars
0
Forks
0
Avg merge
6h 14m
Merged PRs (30d)
27

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AbsaOSS/living-doc

All issues in AbsaOSS/living-doc

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.