PRs closed without merge are still part of the draft

Open Beginner friendly
#361 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
github-actions, python
Domain
devops, release

Research direction

Start by finding the code that gathers pull requests for a release draft and the tests that cover closed pull requests. Reproduce the reported case with a closed, unmerged PR and check how its state is handled. Done means closed PRs without a merge are omitted from the draft while merged PRs remain included.

Written by the indexing model from the issue text.

Description

bug
Describe the bug

PRs closed without merge are still part of the draft. Typical cases are refused DependeBot PRs, or PRs that were superseded by others

This seems wrong. They are not part of the release in any sense.

Steps to Reproduce
  1. Create a PR
  2. Close the PR without merging it
  3. Create release draft
  4. PR is mentioned in the draft
Expected state

These PRs are ignored

Impact / Severity

Medium

Attachments / Evidence
image
Desktop

No response

Related / References

No response

Dominant language
Python
Stars
12
Forks
0
Avg merge
1m
Merged PRs (30d)
6

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AbsaOSS/generate-release-notes

All issues in AbsaOSS/generate-release-notes

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.