PRs closed without merge are still part of the draft
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 66/100
Research direction
Start by finding the code that gathers pull requests for a release draft and the tests that cover closed pull requests. Reproduce the reported case with a closed, unmerged PR and check how its state is handled. Done means closed PRs without a merge are omitted from the draft while merged PRs remain included.
Written by the indexing model from the issue text.
Description
Describe the bug
PRs closed without merge are still part of the draft. Typical cases are refused DependeBot PRs, or PRs that were superseded by others
This seems wrong. They are not part of the release in any sense.
Steps to Reproduce
- Create a PR
- Close the PR without merging it
- Create release draft
- PR is mentioned in the draft
Expected state
These PRs are ignored
Impact / Severity
Medium
Attachments / Evidence
Desktop
No response
Related / References
No response
- Dominant language
- Python
- Stars
- 12
- Forks
- 0
- Avg merge
- 1m
- Merged PRs (30d)
- 6
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AbsaOSS/generate-release-notes
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
-
In newly created draft hashes are not linked.Possibly taken @bfs2021 claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
Release v1.4.0Possibly taken @miroslavpojer claimed this 1 day ago. Openepic
AbsaOSS/generate-release-notes#358 · 1 assignee ·
-
Fix broken workflow examples and stale action version commentsPossibly taken @miroslavpojer claimed this 1 day ago. Openbug documentation tech debt
AbsaOSS/generate-release-notes#356 · 1 assignee ·
All issues in AbsaOSS/generate-release-notes
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
abetlen/llama-cpp-python#2424 ·
Maintainers usually reply within 1 day
-
Bug IronPython Python 3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyrevitlabs/pyRevit#4184 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
jqueryscript/awesome-claude-code#1009 ·
-
tests
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day