Disabling an open Autocomplete still allows option changes

Open
#950 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
angular, typescript
Domain
frontend

Research direction

The bug is in the Autocomplete component's disabled input handling while its option panel is open. Start by finding where disabled is read and where option click handlers emit valueChanged, then check whether the open panel is closed when disabled becomes true. Done when the reproduction steps leave the value at Apple, close the options, and fire no valueChanged event, with a test that toggles disabled while the panel is open.

Written by the indexing model from the issue text.

Description

Reproduction
  1. Render the Autocomplete with Apple selected and open its options.
  2. Set the control's disabled input to true while the options are open.
  3. Click Orange in the list.

Chrome reproduction

Expected behavior

The options close, the value stays Apple, and no valueChanged event fires.

Actual behavior

The options stay interactive. Clicking Orange changes the value and fires an event.

Reproduced in Chrome 157 on master at aa80e58.

Dominant language
TypeScript
Stars
9
Forks
8
Avg merge
1d 6h
Merged PRs (30d)
25

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AbsaOSS/cps-shared-ui

All issues in AbsaOSS/cps-shared-ui

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.