Support built-in disabling mechanism for reactive form controls instead of applying disabled attribute
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- angular, typescript
- Domain
- frontend
Research direction
No file or test is named in the issue. Start by locating the shared components that use Angular reactive form controls and review how they currently apply the disabled attribute; compare that behavior with FormControl creation using disabled and the enable()/disable() APIs. Done means reactive controls can use Angular's built-in disabling mechanism without the current warning or direct disabled-attribute handling.
Written by the indexing model from the issue text.
Description
It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true
when you set up this control in your component class, the disabled attribute will actually be set in the DOM for
you. We recommend using this approach to avoid 'changed after checked' errors.
Example:
// Specify the `disabled` property at control creation time:
form = new FormGroup({
first: new FormControl({value: 'Nancy', disabled: true}, Validators.required),
last: new FormControl('Drew', Validators.required)
});
// Controls can also be enabled/disabled after creation:
form.get('first')?.enable();
form.get('last')?.disable();
- Dominant language
- TypeScript
- Stars
- 9
- Forks
- 7
- Avg merge
- 11h 59m
- Merged PRs (30d)
- 8
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from AbsaOSS/cps-shared-ui
-
enhancement library
Difficulty 1/5 Under an hour Newbie friendliness 85/100
AbsaOSS/cps-shared-ui#644 ·
Maintainers usually reply within 1 day
-
library new component
Difficulty 3/5 Half a day Newbie friendliness 55/100
AbsaOSS/cps-shared-ui#853 ·
Maintainers usually reply within 1 day
-
library new component
Difficulty 3/5 1-2 days Newbie friendliness 62/100
AbsaOSS/cps-shared-ui#792 ·
Maintainers usually reply within 1 day
-
library tech-debt
Difficulty 3/5 1-2 days Newbie friendliness 55/100
AbsaOSS/cps-shared-ui#692 ·
Maintainers usually reply within 1 day
-
library tech-debt
Difficulty 3/5 1-2 days Newbie friendliness 55/100
AbsaOSS/cps-shared-ui#691 ·
Maintainers usually reply within 1 day
All issues in AbsaOSS/cps-shared-ui
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
homarr-labs/dashboard-icons#2939 ·
Maintainers usually reply within 1 day
-
Agent/category reasoning variants are still checked against the stale model cache in chat.paramsOpenopencode
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
code-yeongyu/oh-my-openagent#10003 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Actions on ToastsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nextcloud-libraries/nextcloud-dialogs#2669 ·
Maintainers usually reply within 1 day