[BUG] Mapping table for ID_AA64ISAR0_EL1 is incorrect for FEAT_SHA1 and FEAT_SHA512
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- documentation
Research direction
Start at the ACLE documentation's mapping section and compare the SHA feature rows with the linked ID_AA64ISAR0_EL1 documentation. Update the mapping so each SHA feature has its correct dependent register and value, then verify the rendered table and surrounding links remain correct.
Written by the indexing model from the issue text.
Description
Describe the bug
The mapping table has the following rows:
| Architecture name | Name | Dependent feature registers |
|---|---|---|
| FEAT_SHA1, FEAT_SHA256 | sha2 | ID_AA64ISAR0_EL1.SHA2 >= 0b0001 |
| FEAT_SHA512, FEAT_SHA3 | sha3 | ID_AA64ISAR0_EL1.SHA3 >= 0b0001 |
https://arm-software.github.io/acle/main/acle.html#mapping
But this isn't quite correct. It's true that, confusingly, FEAT_SHA1 is grouped under sha2 and FEAT_SHA512 is grouped under sha3, but their ID_AA64ISAR0_EL1 values are not grouped. Per the ID_AA64ISAR0_EL1 documentation:
FEAT_SHA1isID_AA64ISAR0_EL1.SHA1 >= 0b0001FEAT_SHA512isID_AA64ISAR0_EL1.SHA2 >= 0b0010
I think these rows probably need to be split into four, something like:
| Architecture name | Name | Dependent feature registers |
|---|---|---|
| FEAT_SHA1 | sha2 | ID_AA64ISAR0_EL1.SHA1 >= 0b0001 |
| FEAT_SHA256 | sha2 | ID_AA64ISAR0_EL1.SHA2 >= 0b0001 |
| FEAT_SHA512 | sha3 | ID_AA64ISAR0_EL1.SHA2 >= 0b0010 |
| FEAT_SHA3 | sha3 | ID_AA64ISAR0_EL1.SHA3 >= 0b0001 |
- Dominant language
- Python
- Stars
- 129
- Forks
- 77
- Avg merge
- 8d 12h
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ARM-software/acle
-
[BUG] Reinterpret cast (vreinterpret*) table has 10 missing rows and 2 incorrect rows for AArch32Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ARM-software/acle#442 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
ARM-software/acle#463 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ARM-software/acle#436 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 48/100
ARM-software/acle#426 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 38/100
ARM-software/acle#408 ·
All issues in ARM-software/acle
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
instance instance add
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
searxng/searx-instances#941 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
FluidNumerics/fluid-walk-blocker#89 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day