master CI red since 3d16d77db: jcode-app-core lib tests do not compile on Windows (E0433, tests module gated not(windows))
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start with the cfg gates and call site in crates/jcode-app-core/src/tool/bash.rs around lines 1310 and 1491, then inspect bash_tests.rs to see which test pieces are platform-specific. Reproduce with the Windows target command given in the issue. Done means the library test target compiles on Windows and the test launch gate is consistently gated.
Written by the indexing model from the issue text.
Description
Summary
Since 3d16d77db (2026-10-30), the Build & Test (windows-latest) CI job cannot compile the jcode-app-core library test target on master: error[E0433]: cannot find module or crate tests`` at crates/jcode-app-core/src/tool/bash.rs:1310. The commit is `bce1bbecb` (per-session environment snapshot, #1969).
Steps to reproduce
- Check out master at
3d16d77dbor newer on Windows, or read any CI run since https://github.com/1jehuang/jcode/actions/runs/41042420189 (jobBuild & Test (windows-latest)). - Build the test target:
cargo test --locked --target x86_64-pc-windows-msvc --lib --bins --no-run.
Expected
The library test target compiles on Windows.
Actual
error[E0433]: cannot find module or crate tests in this scope pointing at bash.rs:1310:
- The call site is gated
#[cfg(test)]only:tests::wait_for_session_env_launch_gate(&session_id_env).await; - But the module is declared
#[cfg(all(test, not(windows)))]with#[path = "bash_tests.rs"] mod tests;(bash.rs:1491-1493), so on Windowstestsdoes not exist at all.
Every master CI run since3d16d77dbfails this step (runs 41042420189, 41018079592 and the three before it), and PR runs that compile app-core lib tests fail identically.
Proposed fix
Align the two cfg gates. Either widen the module to #[cfg(test)] and keep the unix-only pieces inside bash_tests.rs under their own #[cfg(unix)] guards, or gate the call site #[cfg(all(test, not(windows)))] to match the module. The call is a test launch gate, so matching the module gate is the smaller change.
Happy to open a PR if you want.
- Dominant language
- Rust
- Stars
- 19.9k
- Forks
- 2.3k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 41
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from 1jehuang/jcode
-
Add GPT-6.1 Terra to the OpenAI model libraryPossibly taken @Aafimalek claimed this 2 days ago. Opentriage: needs-decision
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
1jehuang/jcode#1997 · 2 comments ·
Maintainers usually reply within 2 days
-
bug needs-info triage: unclear
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
1jehuang/jcode#1823 · 2 comments ·
Maintainers usually reply within 2 days
-
master is red past formatting since 089947b02: Windows E0596 in jcode-companion and a macOS warning-budget overrunPossibly taken @akushonkamen claimed this 17 days ago. Openarea: ci bug platform: macos platform: windows triage: needs-decision
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
1jehuang/jcode#1803 · 3 comments ·
Maintainers usually reply within 2 days
-
Nine tracked source files are compiled by nothing (dead code left by the crate splits and renames)Openautonomous: no tech-debt triage: needs-decision
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
1jehuang/jcode#1795 · 1 comment ·
Maintainers usually reply within 2 days
-
iOS: replies lost when the phone disconnects mid-turnPossibly taken @0x7067 claimed this 31 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 2 days
Similar issues
-
bug priority: low ui
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
storytold/photocraft#10370 · 1 comment ·
Maintainers usually reply within 1 day
-
area:doc bug in progress needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
bherbruck/solvecraft#9634 · 2 comments · 1 reaction ·
-
inflate: total_in uses plain += on c_ulong (32-bit on Windows), panics in debug for streams > 4 GiBOpen
Difficulty 1/5 Under an hour Newbie friendliness 85/100
trifectatechfoundation/zlib-rs#570 · 1 comment ·
-
bug discord-triage
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
LanternOps/breeze#10755 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
aranya-project/aranya#803 ·