Page reload websocket connection doesn't use `pathPrefix`

Open
#89 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
backend, networking

Research direction

Start by tracing the dev server's websocket connection setup and how pathPrefix is applied to other served files. Reproduce the connection through an Nginx reverse proxy, then verify that reload notifications connect and function under the configured pathPrefix.

Written by the indexing model from the issue text.

Description

We want to use the eleventy dev server behind a reverse proxy, utilising Nginx.

However, the websocket connection, to get notified of changes, always connects to ws://localhost and does not respect the pathPrefix. All other files are served from the pathPrefix path correctly.

What do you think about using the pathPrefix for ws connections as well?

Dominant language
JavaScript
Stars
109
Forks
20
Avg merge
1m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from 11ty/dev-server

All issues in 11ty/dev-server

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.