Revisit post index mapping data types
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with includes/mappings/post/7-0.php at the cited thumbnail, facet, post type, and numeric field entries, then review all other mapping files as requested. Compare the current types and facet behavior against the issue, and treat the work as done when the agreed mapping changes are applied consistently and the required reindex is accounted for.
Written by the indexing model from the issue text.
Description
Is your enhancement related to a problem? Please describe.
We could improve some of the data types in mappings.
Describe the solution you'd like
- Thumbnail src from
texttokeyword: https://github.com/10up/ElasticPress/blob/develop/includes/mappings/post/7-0.php#L445 (this is similar to other URL data like https://github.com/10up/ElasticPress/blob/develop/includes/mappings/post/7-0.php#L386) - Facet field is always sent in the post mapping, it probably shouldn't if the facet feature is deactivated, as there would be no practical purpose having it: https://github.com/10up/ElasticPress/blob/develop/includes/mappings/post/7-0.php#L245
ep_custom_resulttaxonomy should not have a facet field.- Post type. Should it have text fields instead of just a keyword ? https://github.com/10up/ElasticPress/blob/develop/includes/mappings/post/7-0.php#L371
- ID, menu_order and other numeric data to
keywordhttps://github.com/10up/ElasticPress/blob/develop/includes/mappings/post/7-0.php#L266: Elastic recommends using keyword instead ofintegerorlongif we are not expecting to perform range queries https://www.elastic.co/guide/en/elasticsearch/reference/current/keyword.html
Designs
Describe alternatives you've considered
Additional context
- We need to make sure to update all mapping files
- A reindex will be needed
- Dominant language
- PHP
- Stars
- 1.3k
- Forks
- 325
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 24
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from 10up/ElasticPress
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
10up/ElasticPress#4402 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
10up/ElasticPress#4390 ·
Maintainers usually reply within 1 day
-
[Release] 5.3.6Open
Difficulty 4/5 3-5 days Newbie friendliness 15/100
10up/ElasticPress#4388 ·
Maintainers usually reply within 1 day
-
Move AI Features from ElasticPress Labs to the ElasticPress PluginPossibly taken @ZacharyRener claimed this 124 days ago. Openenhancement
10up/ElasticPress#4316 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Convert Pointers class to functional componentPossibly taken @ZacharyRener claimed this 288 days ago. Openenhancement
10up/ElasticPress#4261 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in 10up/ElasticPress
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getgrav/grav-plugin-sitemap#125 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
nikic/PHP-Parser#1184 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
shukiv/jabali-panel#2474 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100