zulip/zulip

Rename `dm-including` search filter to `dm-with`

Open

#34,932 opened on Jun 18, 2025

View on GitHub
聽(17 comments)聽(0 reactions)聽(0 assignees)Python聽(19,672 stars)聽(7,339 forks)batch import
area: searchhelp wanted

Description

As suggested at #design > Add mentions:user search filter #34751 @ 馃挰, dm-with is a better name for the filter currently called dm-including. We should rename it.

We should offer backwards compatibility like we do for stream:, where typing dm-including suggests dm-with.

All documentation (including ? menu and help center) should be updated.

Contributor guide

Tech stack
python
Domain
backendfrontenddocumentationsearch
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Zulip's search filter implementation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Identify the search filter parsing logic in the backend (likely in zerver/lib/) where 'dm including' is defined. Rename it to 'dm with' and add a backward compatibility mapping so that 'dm including' suggests the new name. Update the frontend search suggestion logic (probably in static/js/) to show the new filter. Update all user facing documentation including the '?' menu and help center pages to use 'dm with'. Review the discussion in the linked chat for additional context.
Rename `dm-including` search filter to `dm-with` 路 zulip/zulip#34932 | Good First Issue