zulip/zulip

Move example domain used by test suite to @example.com

Open

#1,118 opened on Jun 25, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (19,672 stars) (7,339 forks)batch import
area: testing-infrastructurehelp wantedpriority: high

Description

This makes more sense than @zulip.com.

Probably to make this easy, we'll want to first do a series of commits doing refactoring to stop hardcoding e.g. hamlet@zulip.com in every test and instead at least be accessing something like self.email from the test class, so it's easier to make changes to these things, and then actually make the change.

Contributor guide

Tech stack
python
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python testing basicsUnderstanding of test fixturesFamiliarity with Zulip test suite
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, identify all test files that hardcode email addresses like hamlet@zulip.com. Then, create a base test class with a self.email property or similar, and update each test to use that instead. Finally, replace all instances of @zulip.com with @example.com across the test suite. Refer to the issue comments for additional guidance.
Move example domain used by test suite to @example.com · zulip/zulip#1118 | Good First Issue