zulip/zulip

Move example domain used by test suite to @example.com

Open

#1,118 opened on Jun 25, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (7,339 forks)batch import
area: testing-infrastructurehelp wantedpriority: high

Repository metrics

Stars
 (19,672 stars)
PR merge metrics
 (Avg merge 36d 6h) (110 merged PRs in 30d)

Description

This makes more sense than @zulip.com.

Probably to make this easy, we'll want to first do a series of commits doing refactoring to stop hardcoding e.g. hamlet@zulip.com in every test and instead at least be accessing something like self.email from the test class, so it's easier to make changes to these things, and then actually make the change.

Contributor guide

Research direction
Identify all occurrences of hardcoded email addresses like hamlet@zulip.com in test files, refactor to use a centralized constant or test class method, and then replace the domain with @example.com.
Tech stack
python
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65