zulip/zulip-mobile

Excessive space around numbered list

Open

#4,492 opened on Feb 20, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (673 forks)github user discovery
a-layouta-message listhelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

@kasperg reported the following behavior at zulip/zulip#17284: image

There are two things that are quite wrong here:

  1. There's too much space between the paragraph and the following list.
  2. The list items are too deeply indented.

By contrast, we have pretty reasonable behavior with a plain bulleted list. We should use the same spacing for numbered lists as for bulleted lists.

(It's possible the spacing for bulleted lists should be slightly tweaked, too. But first let's make both kinds behave the same way, and then we can tweak them both together.)

A good comparison to look at is the webapp's behavior. See https://github.com/zulip/zulip/commit/03e4ccbc2d6f092e84cda20b06c20cef3e94e565 which recently adjusted this for the webapp.

Contributor guide

Research direction
Inspect the list rendering component in the codebase, compare the styling applied to bulleted lists versus numbered lists, and identify the CSS/React Native style properties causing excessive space and indentation. Consider the recent webapp fix for reference.
Tech stack
javascriptreactreact native
Domain
mobilefrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70