zulip/zulip-mobile

Debug AnimatedComponent getting stuck with rapid changes in state

Open

#3,899 opened on Feb 12, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
experimental UI/UXhelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

Good animations can go a long way to smooth out rough edges, and currently we're being blocked from using more of them.

876f22d1aec9580ac053849b2c0ffaf1891b99fb reverted the use of AnimatedComponent for the OfflineNotice because of this issue:

When disconnecting from a VPN on Android 9 and later, the connection state goes from 'vpn' to 'none' to 'wifi' very quickly. This can result in the online banner getting stuck in mid-animation, until some other event (e.g. the user scrolling) causes a redraw.

I haven't had time to reproduce it, yet, but we'll need a consistent reproduction before we can continue using AnimatedComponent. I'd especially like to use it for a loading banner in https://github.com/zulip/zulip-mobile/issues/3387.

Contributor guide

Research direction
Create a minimal reproduction of rapid state changes causing AnimatedComponent to get stuck. Trace the animation lifecycle and identify where the interruption occurs.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
React NativeAnimated API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40