zsh-users/zsh-syntax-highlighting

Block with assignment with no command

Open

#854 opened on Jan 31, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
Buggood first issue

Description

% tests/generate.zsh '{ a=42 }' main block-assignment-no-command
Set copyright year to 2022? y
BUFFER=$'{ a=42 }'

expected_region_highlight=(
  '1 1 reserved-word' # {
  '3 6 assign' # a=42
  '5 6 default' # 42
  '8 8 unknown-token' # }
)

That's a valid command so the final } should be a reserved-word.

Contributor guide

Tech stack
shell
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
zsh syntaxtesting with zsh syntax highlighting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue describes a case where an assignment inside a block (e.g., `{ a=42 }`) is incorrectly highlighted: the closing brace `}` is marked as `unknown token` instead of `reserved word`. To fix, examine the syntax highlighting logic in the repository, likely in files like `highlighters/main/main highlighter.zsh`. The test file `tests/generate.zsh` shows the expected output. Modify the highlighting rules to recognize that assignment with no command is valid in a block, making the `}` a reserved word. Confirm the fix by running the test suite.