zsh-users/zsh-syntax-highlighting

History expansion followed by non-history char

Open

#713 opened on Mar 22, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
Improvementgood first issue

Description

A history expansion followed by a character ineligible for history expansion (e.g. =) isn't highlighted correctly. !!= unquoted is all highlighted as history expansion and "!!=" terminates the history expansion style on the first ! rather than the second.

Contributor guide

Tech stack
shell
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of Zsh history expansionFamiliarity with regex pattern matching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the highlighting rules for history expansion in the zsh syntax highlighting codebase, likely in the 'highlighters' folder. Identify the regex patterns that handle history expansion and adjust them to correctly handle cases like '!!=' (unquoted) and '"!!="' (quoted). Test with appropriate test cases to ensure both scenarios are covered.