zsh-users/zsh-syntax-highlighting

path,single-quoted-string style combination regressed

Open

#707 opened on Mar 19, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
BugRegressionUpstreamgood first issue

Description

As #475 pointed out, when ./foo existed, : 'f'oo highlighted the 'f' in underline,fg=yellow and the oo in underline. That regressed — bisected to 6835121eafa49899b396f5f85207fb1fe229bc1c. It'd be nice to have it back ☺

Contributor guide

Tech stack
shell
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with zsh syntax highlighting codebaseUnderstanding of shell syntax highlighting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the commit 6835121eafa49899b396f5f85207fb1fe229bc1c that caused the regression. Review the previous behavior described in issue #475. Understand the highlighting logic for path and single quoted string combinations. Look at the existing test cases and adjust the regex or parsing to restore the old behavior.