zsh-users/zsh-syntax-highlighting

Audit for null argument elision

Open

#479 opened on Jan 12, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
Taskgood first issue

Description

See https://github.com/zsh-users/zsh-syntax-highlighting/pull/471#issuecomment-357249607

Go through the code, wherever there's an unquoted parameter name, see if it needs to be double quoted to guard against null argument elision (SH_WORD_SPLIT doesn't prevent that).

Contributor guide

Tech stack
shell
Domain
developer experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of zsh quoting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Audit the entire codebase for unquoted parameter expansions that could cause null argument elision. Refer to the discussion in PR #471 for context. Each occurrence should be evaluated and double quoted if necessary. Focus on files containing parameter expansions, especially in highlighters and functions.