zsh-users/zsh-syntax-highlighting

Audit for null argument elision

Open

#479 opened on Jan 12, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Shell (1,371 forks)batch import
Taskgood first issue

Repository metrics

Stars
 (22,617 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See https://github.com/zsh-users/zsh-syntax-highlighting/pull/471#issuecomment-357249607

Go through the code, wherever there's an unquoted parameter name, see if it needs to be double quoted to guard against null argument elision (SH_WORD_SPLIT doesn't prevent that).

Contributor guide

Research direction
Inspect the codebase for unquoted parameter names and determine if they require double quoting to prevent null argument elision.
Tech stack
shell
Domain
clideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitZsh
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70