zsh-users/zsh-syntax-highlighting

Highlight case/esac

Open

#406 opened on Dec 29, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Shell (1,371 forks)batch import
Improvementgood first issue

Repository metrics

Stars
 (22,617 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In case foo in (bar) ls;; esac:

  • The ls not highlighted as a command word.
  • The esac is not highlighted as a reserved word.
  • The case/esac pair should be subject to balanced-parenthesis logic, like do/done. (So esac is highlighted in red if not preceded by a case, etc.)
  • If the second word after case is not in, then it is a syntax error.

Contributor guide

Research direction
Examine the syntax highlighting rules for 'case' and 'esac' in the zsh syntax highlighting source code. Identify where the highlighting fails for 'ls' after a case pattern and for 'esac' as a reserved word. Consider implementing balanced parenthesis logic similar to 'do'/'done'.
Tech stack
shell
Domain
clideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Shell scriptingGitZsh basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65