zsh-users/zsh-syntax-highlighting

Highlight case/esac

Open

#406 opened on Dec 29, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
Improvementgood first issue

Description

In case foo in (bar) ls;; esac:

  • The ls not highlighted as a command word.
  • The esac is not highlighted as a reserved word.
  • The case/esac pair should be subject to balanced-parenthesis logic, like do/done. (So esac is highlighted in red if not preceded by a case, etc.)
  • If the second word after case is not in, then it is a syntax error.

Contributor guide

Tech stack
shell
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of zsh syntaxfamiliarity with the highlighting codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate how case/esac is currently handled in the syntax highlighting code (likely in highlighters/main.zsh or similar). Look at the existing balanced parenthesis logic for do/done and replicate for case/esac. Ensure that 'ls' after a pattern is recognized as a command word. Test with the provided example 'case foo in (bar) ls;; esac' and verify all checkboxes.
Highlight case/esac · zsh-users/zsh-syntax-highlighting#406 | Good First Issue