zsh-users/zsh-syntax-highlighting

Highlight trailing garbage as error

Open

#296 opened on Apr 22, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
Improvementgood first issue

Description

% if :; then fi
% if :; then fi foobar
zsh: parse error near `foobar'
% for arg; do done    
% for arg; do done fobar
zsh: parse error near `fobar'

The foobar should be highlighted as an error ([unknown-token]).

Contributor guide

Tech stack
shell
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of zsh syntaxfamiliarity with syntax highlighting plugin architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the highlighting code, likely in the `highlighters/main` directory or similar. The issue highlights trailing garbage like 'foobar' after 'done' in a for loop should be marked as an error (`unknown token`). Look at how existing errors like parse errors are highlighted and extend that logic to cover trailing words after valid commands. Refer to issue #296 for details.