zsh-users/zsh-syntax-highlighting

Highlight trailing garbage as error

Open

#296 opened on Apr 22, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Shell (1,371 forks)batch import
Improvementgood first issue

Repository metrics

Stars
 (22,617 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

% if :; then fi
% if :; then fi foobar
zsh: parse error near `foobar'
% for arg; do done    
% for arg; do done fobar
zsh: parse error near `fobar'

The foobar should be highlighted as an error ([unknown-token]).

Contributor guide

Research direction
Examine the highlighting logic in the zsh syntax highlighting codebase to understand why trailing garbage after constructs like 'if :; then fi' is not highlighted as an unknown token error. Look at the parser that tokenizes and assigns highlight groups, particularly for the 'fi' keyword and subsequent text.
Tech stack
shell
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
zshGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65