zsh-users/zsh-syntax-highlighting

path_prefix: Use short-circuit glob qualifier

Open

#210 opened on Sep 30, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Shell (1,371 forks)batch import
Taskgood first issueperformance

Repository metrics

Stars
 (22,617 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

zsh-5.0.6 and newer include the (Y) glob qualifier, which causes a glob pattern to stop looking for matches in the filesystem as soon as N matches have been found.

_zsh_highlight_main_highlighter_check_path should use (Y1), if supported, when testing the path_prefix case. This might make a difference in highlighting of glob patterns that apply to large directories or under slow mount points.

Contributor guide

Research direction
Implement the use of the (Y1) glob qualifier in the path prefix check to stop early after one match, improving performance in large directories.
Tech stack
shell
Domain
cli
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitzsh
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70