zsh-users/zsh-syntax-highlighting

path_prefix: Use short-circuit glob qualifier

Open

#210 opened on Sep 30, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Shell (22,617 stars) (1,371 forks)batch import
Taskgood first issueperformance

Description

zsh-5.0.6 and newer include the (Y) glob qualifier, which causes a glob pattern to stop looking for matches in the filesystem as soon as N matches have been found.

_zsh_highlight_main_highlighter_check_path should use (Y1), if supported, when testing the path_prefix case. This might make a difference in highlighting of glob patterns that apply to large directories or under slow mount points.

Contributor guide

Tech stack
shell
Domain
backendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of zsh glob qualifiers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Look at the function ` zsh highlight main highlighter check path` in the zsh syntax highlighting source code. Implement logic to detect if zsh version supports the (Y) glob qualifier (version 5.0.6+), and if so, use (Y1) in the path prefix test. Ensure the change does not break existing functionality for older zsh versions. Test with large directories or slow mount points to verify performance improvement.