zilliztech/milvus-helm

Allow custom annotations to node svc

Open

#133 opened on Oct 18, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go Template (77 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (119 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently datanode, indexnode, querynode does not allow additional service annotations like

{{- with .Values.service.annotations }}
  annotations:
{{ toYaml . | indent 4 }}

why: currently monitoring supports only prometheus way via servicemonitor. With annotations, one could use vmagent to scrape services based on annotations.

Contributor guide

Research direction
Review the Helm templates for datanode, indexnode, and querynode services in the templates/ directory and add a conditional block to include custom annotations from .Values.service.annotations.
Tech stack
kubernetes
Domain
infrastructuredevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitKubernetesHelm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80