zhanghai/MaterialRatingBar

Stars not reflecting user input

Open

#28 opened on Nov 17, 2017

View on GitHub
 (7 comments) (7 reactions) (1 assignee)Java (1,947 stars) (206 forks)batch import
bughelp wanted

Description

I think this is a general issue with the RatingBar for Android, but wanted to post here to be sure as I couldn't find a definitive answer.

We have the MaterialRatingBar in our app (love it btw), using width=match_parent.

On some devices, when the user taps 1 star, the 2nd star updates. If they tap the 2nd star, the 3rd updates etc. User can never select 1 star and the star they select is never the correct one.

Samsung devices seem to suffer the worst with this issue. It works fine as well on plenty of devices. If we get rid of match_parent, it seems to work on all devices too.

Contributor guide

Tech stack
androidjava
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development experienceCustom View measurement
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the MaterialRatingBar source code, particularly the onTouchEvent and onMeasure methods, to understand how touch coordinates are translated to star selection. Examine the issue comments for device specific details and any suggested workarounds. Test with different layout widths to reproduce the bug on a Samsung device. Consider whether the issue lies in touch coordinate calculation when the view width is set to match parent.