zulip/zulip

Use a caching template loader in development

Open

#627 创建于 2016年4月2日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (19,672 star) (7,339 fork)batch import
area: toolinghelp wanted

描述

If we can make this work, this should substantially improve page load times in development with pretty minimal cost (just a bit of extra complexity).

Larger pages like / and /integrations are way faster in prod because of this block in zproject/settings.py:

if PRODUCTION:                                                                                                          
    # Template caching is a significant performance win in production.                                                  
    TEMPLATE_LOADERS = (                                                                                                
        ('django.template.loaders.cached.Loader',                                                                       
         TEMPLATE_LOADERS),                                                                                             
        )

So most of the processing it only does once per template rather than once per request. We can't use that in development right now, because the way that caching works it doesn't update the cache when a user changes the template content. It should be possible to add a mechanism for invalidating that cache whenever changes are made in the repository (we certainly already have autoreload code listening for changes to frontend templates in tools/compile-handlebars-templates, and it shouldn't hard to tweak that to do Django templates as well; we just need to read the Django cached loader's code to find out what we need to do in order to update/invalidate the cache).

Based on a follow-up to #545.

贡献者指南

技术栈
pythondjango
领域
backenddeveloper experienceperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic PythonDjango framework knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue proposes using Django's cached template loader in development, similar to production, but with cache invalidation on template changes. To implement this, read the production caching block in zproject/settings.py and the existing autoreload code for frontend templates in tools/compile handlebars templates. You'll need to study Django's 'django.template.loaders.cached.Loader' to understand how to invalidate the cache when templates are modified. The referenced follow up to #545 may provide additional context.