zulip/zulip-mobile

Unread-PMs count is blank if too big

Open

#4,904 创建于 2021年7月17日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (673 fork)github user discovery
help wanted

仓库指标

Star
 (1,348 star)
PR 合并指标
 (PR 指标待抓取)

描述

The count we show on the "people" icon that leads to the PMs tab can look like this: image I.e., there's a little bubble there… but instead of having a number inside, it's just blank, and so it looks broken.

This happens when the count is 100 or more. Specifically:

  • I got that symptom when logged in as a test account that had 139 unread PMs.
  • Then I went and read the messages one by one from a different client. The symptom stayed the same as the number of unread PMs went down to 100.
  • As soon as the number became 99, it showed up properly: image

I suspect what's happening involves the fact that the number is too long to really fit in that space.

Instead, when this count is big, we should probably just say something like "99+".

贡献者指南